]> dgit.raspbian.org Git - gnome-shell.git/commit
popupMenu: Don't chain up vfuncs if the parent doesn't implement them
authorJonas Dreßler <verdre@v0yd.nl>
Sun, 27 Oct 2019 21:28:38 +0000 (22:28 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Mon, 28 Oct 2019 13:43:55 +0000 (13:43 +0000)
commitc35b4cede58142797b1f6b04a4e2e7eaa938234a
tree159d08bb7a9e74cc55fff055f9ff410f0f518c9e
parent6cfcfc72cc11a55b7a59ca2f290f26358889e6d8
popupMenu: Don't chain up vfuncs if the parent doesn't implement them

Some vfuncs like `button_press_event`, `button_release_event` and
`touch_event` don't have handlers in the parent classes of
PopupBaseMenuItem. So don't call those handlers and return the default
Clutter.EVENT_PROPAGATE there.

This fixes a crash of the shell that happens when pressing a mouse
button inside the system popup menu and releasing it above a slider like
the volume slider again.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/787
js/ui/popupMenu.js